Deduplicate some code #9205
Merged
Deduplicate some code #9205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanh
force-pushed
the
enable-users-to-call-add-member-API
branch
from
e79457b to
8491ea9
Compare
seanh
force-pushed
the
refactor-predicates
branch
from
eb1e7c1 to
d4930e6
Compare
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (2)
tests/unit/h/security/identity_test.py:145
- Ensure that GroupMembershipRoles is correctly imported and used in the test cases.
roles=[GroupMembershipRoles.MODERATOR]
tests/unit/h/security/identity_test.py:149
- Ensure that the test case is correctly validating the returned roles from get_roles method.
assert identity.get_roles(group) == [GroupMembershipRoles.MODERATOR]
mtomilov
approved these changes
Jan 5, 2025
seanh
force-pushed
the
refactor-predicates
branch
from
d4930e6 to
8edacf2
Compare
seanh
changed the base branch from
enable-users-to-call-add-member-API
to
main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.