Skip to content

fixed #25 (Events are not passed through to the foreground view if STICKY_HEADER_HEIGHT overlaps) #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed #25 (Events are not passed through to the foreground view if STICKY_HEADER_HEIGHT overlaps) #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,15 +276,20 @@ class ParallaxScrollView extends Component {
const { viewWidth, scrollY } = this.state;
if (renderStickyHeader || renderFixedHeader) {
const p = pivotPoint(parallaxHeaderHeight, stickyHeaderHeight);
let height = interpolate(scrollY, {
inputRange: [0, stickyHeaderHeight],
outputRange: [0, stickyHeaderHeight],
extrapolate: 'clamp'
});
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe height need to be declared as const, don't see it changing later in code.
Also maybe it could be replaced with call to interpolate in View parameters, similar to opacity

return (
<View style={[styles.stickyHeader, { width: viewWidth, ...(stickyHeaderHeight ? { height: stickyHeaderHeight } : null ) }]}>
<View style={[styles.stickyHeader, { width: viewWidth }]}>
{
renderStickyHeader
? (
<Animated.View
style={{
backgroundColor: backgroundColor,
height: stickyHeaderHeight,
height: height,
opacity: interpolate(scrollY, {
inputRange: [0, p],
outputRange: [0, 1],
Expand Down