Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update XML element retrieval to use correct parent nodes #3811

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aytee6
Copy link

@aytee6 aytee6 commented Feb 23, 2025

Handling the case when the network security configs already exist under the <debug-overrides/> element.
We should look for the next element under the new element we created/found.

Currently:

<network-security-config>
    <debug-overrides>
        <trust-anchors>
            <certificates src="user" />
            <certificates src="system" /> --- Added line
        </trust-anchors>
    </debug-overrides>
    <base-config /> --- Added line
</network-security-config>

Expected:

<network-security-config>
    <debug-overrides>
        <trust-anchors>
            <certificates src="user" />
        </trust-anchors>
    </debug-overrides>
    <base-config>
        <trust-anchors>
            <certificates src="system" />
            <certificates src="user" />
        </trust-anchors>
    </base-config>
</network-security-config>

Example package: com.tradingview.tradingviewapp

Handling the case when the network security configs already exist under the <debug-overrides> element. Currently only an empty <base-config> element is added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant