fix: IS-3260: Helmfile dep check variable standardization (#60)

* update action yaml and script * update tests * re-build dist Co-authored-by: Marcin Dobosz <[email protected]>
iStreamPlanet · Nov 19, 2020 · 5c9be6a · 5c9be6a
1 parent 178e974
commit 5c9be6a
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/helmfile-dependency-check/__test__/main.test.ts b/helmfile-dependency-check/__test__/main.test.ts
@@ -16,12 +16,12 @@ beforeEach(() => {
 })
 
 afterEach(() => {
-    delete process.env["INPUT_WORKING-DIR"]
+    delete process.env["INPUT_WORKING_DIRECTORY"]
 })
 
 describe("helmfile-dep-update", () => {
     it("helmfile missing", async () => {
-        process.env["INPUT_WORKING-DIR"] = path.join(baseDir, "helmfile-missing")
+        process.env["INPUT_WORKING_DIRECTORY"] = path.join(baseDir, "helmfile-missing")
         const setOutputMock = jest.spyOn(core, "setOutput")
 
         await helmfileDepCheck()
@@ -30,7 +30,7 @@ describe("helmfile-dep-update", () => {
         expect(setOutputMock).toHaveBeenCalledWith("helmfile-lock-updates", [])
     })
     it("helmfile missing repositories", async () => {
-        process.env["INPUT_WORKING-DIR"] = path.join(baseDir, "helmfile-no-repository")
+        process.env["INPUT_WORKING_DIRECTORY"] = path.join(baseDir, "helmfile-no-repository")
         const setOutputMock = jest.spyOn(core, "setOutput")
 
         await helmfileDepCheck()
@@ -39,7 +39,7 @@ describe("helmfile-dep-update", () => {
         expect(setOutputMock).toHaveBeenCalledWith("helmfile-lock-updates", [])
     })
     it("helmfile lock fresh", async () => {
-        process.env["INPUT_WORKING-DIR"] = path.join(baseDir, "helmfile-lock-fresh")
+        process.env["INPUT_WORKING_DIRECTORY"] = path.join(baseDir, "helmfile-lock-fresh")
         const setOutputMock = jest.spyOn(core, "setOutput")
 
         await helmfileDepCheck()
@@ -48,7 +48,7 @@ describe("helmfile-dep-update", () => {
         expect(setOutputMock).toHaveBeenCalledWith("helmfile-lock-updates", [])
     })
     it("helmfile lock update", async () => {
-        process.env["INPUT_WORKING-DIR"] = path.join(baseDir, "helmfile-lock-update")
+        process.env["INPUT_WORKING_DIRECTORY"] = path.join(baseDir, "helmfile-lock-update")
         const setOutputMock = jest.spyOn(core, "setOutput")
 
         await helmfileDepCheck()
@@ -63,7 +63,7 @@ describe("helmfile-dep-update", () => {
         expect(setOutputMock).toHaveBeenCalledWith("helmfile-lock-updates", [updateData])
     })
     it("helmfile lock missing", async () => {
-        process.env["INPUT_WORKING-DIR"] = path.join(baseDir, "helmfile-lock-missing")
+        process.env["INPUT_WORKING_DIRECTORY"] = path.join(baseDir, "helmfile-lock-missing")
         const setOutputMock = jest.spyOn(core, "setOutput")
 
         await helmfileDepCheck()

diff --git a/helmfile-dependency-check/action.yml b/helmfile-dependency-check/action.yml
@@ -4,7 +4,7 @@ runs:
   using: "node12"
   main: "dist/index.js"
 inputs:
-  working-dir:
+  working_directory:
     description: "The directory to run the action in"
     default: "."
 outputs:

diff --git a/helmfile-dependency-check/dist/index.js b/helmfile-dependency-check/dist/index.js
diff --git a/helmfile-dependency-check/helmfileDepCheck.ts b/helmfile-dependency-check/helmfileDepCheck.ts
@@ -52,7 +52,7 @@ export async function helmfileDepCheck() {
             helmfileLockUpdates: []
         }
 
-        const workingDir = getInput("working-dir")
+        const workingDir = getInput("working_directory")
         // path.join is not used, because of issues when building with ncc
         const helmfilePath = process.cwd() + "/" +  workingDir + "/helmfile.yaml"