-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace GeometryStream with GeometryMap. #36
base: core/GeometryDetailRecord
Are you sure you want to change the base?
Replace GeometryStream with GeometryMap. #36
Conversation
@@ -566,14 +565,14 @@ | |||
|
|||
<ECEntityClass typeName="GeometryDetailRecord" modifier="Abstract" displayLabel="Geometry Detail Record" description="An abstract InformationRecordElement that holds geometry for use by the 'feature tree' stored in the `GeometricElement3d.GeometryOperations` property of its parent Element."> | |||
<BaseClass>InformationRecordElement</BaseClass> | |||
<ECProperty propertyName="GeometryStream" typeName="binary" extendedTypeName="GeometryStream" displayLabel="Geometry Stream" description="Binary stream used to persist the geometry of this bis:Element."> | |||
<ECProperty propertyName="GeometryMap" typeName="binary" extendedTypeName="GeometryMap" displayLabel="Geometry Map" description="Binary stream used to persist the geometries of this bis:Element."> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has Brien's code to work with GeometryDetailRecords also been updated to work with GeometryMap instead of GeometryStream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bbastings Looks like there won't be any issues to update the code if/when we decide to merge that branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree.
@@ -566,14 +565,14 @@ | |||
|
|||
<ECEntityClass typeName="GeometryDetailRecord" modifier="Abstract" displayLabel="Geometry Detail Record" description="An abstract InformationRecordElement that holds geometry for use by the 'feature tree' stored in the `GeometricElement3d.GeometryOperations` property of its parent Element."> | |||
<BaseClass>InformationRecordElement</BaseClass> | |||
<ECProperty propertyName="GeometryStream" typeName="binary" extendedTypeName="GeometryStream" displayLabel="Geometry Stream" description="Binary stream used to persist the geometry of this bis:Element."> | |||
<ECProperty propertyName="GeometryMap" typeName="binary" extendedTypeName="GeometryMap" displayLabel="Geometry Map" description="Binary stream used to persist the geometries of this bis:Element."> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a .remarks.md file documenting the format or linking to its documentation. Should also link to docs for the API for working with this stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the remarks, the API is not published to public registry yet.
This PR suggests to change GeometryStream property of GeometryDetailRecord element to GeometryMap.
The main reason for the change is - possibility of huge number of elements and resulting performance issues.
There are some major complications when using GeometryMap, instead of i.e. using relationships to group related geometries.
Suggested FlatBuffer schema for GeometryMap: