Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace extensions rule with more general export rule. Extensions must be public. #64

Merged
merged 6 commits into from
Apr 10, 2024

Conversation

ben-polinsky
Copy link
Collaborator

@ben-polinsky ben-polinsky commented Apr 1, 2024

  • Remove legacy @preview tag - it is meaningless. Was intended to convey beta status for extensions. Now, extensions must have a @public tag.
  • Lint non-extension exported apis to ensure they include one and only one release tag. Lint rule renamed.
  • Some refactoring and cleanup

Issue in core repo: iTwin/itwinjs-core#6573

@ben-polinsky ben-polinsky changed the title Modify extensions rule to accept @beta tags instead of @preview tags Replace extensions rule with more general export rule Apr 2, 2024
@ben-polinsky ben-polinsky changed the title Replace extensions rule with more general export rule Replace extensions rule with more general export rule. Extensions must be public. Apr 3, 2024
@ben-polinsky
Copy link
Collaborator Author

@anmolshres98 @aruniverse we're good to go here, if you want to review.

Copy link
Contributor

@anmolshres98 anmolshres98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good except a couple clarification comments

Copy link
Member

@aruniverse aruniverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just add a beachball change so you can publish a new pre-release

@ben-polinsky
Copy link
Collaborator Author

lgtm, just add a beachball change so you can publish a new pre-release

Have a change. I did set it to major, figured we could finally release 4.0.0.

@aruniverse
Copy link
Member

lgtm, just add a beachball change so you can publish a new pre-release

Have a change. I did set it to major, figured we could finally release 4.0.0.

my bad; missed that. sounds good.

@ben-polinsky ben-polinsky merged commit c989b2f into main Apr 10, 2024
4 checks passed
@ben-polinsky ben-polinsky deleted the bdp/extensions-use-beta branch April 10, 2024 15:07
@paulius-valiunas
Copy link
Collaborator

lgtm, just add a beachball change so you can publish a new pre-release

Have a change. I did set it to major, figured we could finally release 4.0.0.

my bad; missed that. sounds good.

It didn't even take a year 🎉 (but hurry up, you only have a month left 😁)

Jokes aside, perhaps it would be a good time to remove style rules and switch to prettier? On the other hand, I wouldn't really mind another major bump in a month or so.

@ben-polinsky
Copy link
Collaborator Author

lgtm, just add a beachball change so you can publish a new pre-release

Have a change. I did set it to major, figured we could finally release 4.0.0.

my bad; missed that. sounds good.

It didn't even take a year 🎉 (but hurry up, you only have a month left 😁)

Jokes aside, perhaps it would be a good time to remove style rules and switch to prettier? On the other hand, I wouldn't really mind another major bump in a month or so.

I agree - let's get crazy and release another major soon.

@paulius-valiunas
Copy link
Collaborator

Well, I don't want to hold up this release because it's long overdue... but then I also don't want to wait another year just because for some reason we want to keep an arbitrary interval between major versions. These are lint rules, it's not like we have to frequently patch vulnerabilities in previous major versions. We can release them as often as we want and let people update at their own pace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants