-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace extensions rule with more general export rule. Extensions must be public. #64
Conversation
@anmolshres98 @aruniverse we're good to go here, if you want to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good except a couple clarification comments
…error to be reported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just add a beachball change so you can publish a new pre-release
Have a change. I did set it to major, figured we could finally release 4.0.0. |
my bad; missed that. sounds good. |
It didn't even take a year 🎉 (but hurry up, you only have a month left 😁) Jokes aside, perhaps it would be a good time to remove style rules and switch to prettier? On the other hand, I wouldn't really mind another major bump in a month or so. |
I agree - let's get crazy and release another major soon. |
Well, I don't want to hold up this release because it's long overdue... but then I also don't want to wait another year just because for some reason we want to keep an arbitrary interval between major versions. These are lint rules, it's not like we have to frequently patch vulnerabilities in previous major versions. We can release them as often as we want and let people update at their own pace. |
@preview
tag - it is meaningless. Was intended to convey beta status for extensions. Now, extensions must have a@public
tag.Issue in core repo: iTwin/itwinjs-core#6573