Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ESLint 9.11 and typescript-eslint 8.11 #82

Merged
merged 18 commits into from
Oct 23, 2024
Merged

Conversation

wgoehrig
Copy link
Member

@wgoehrig wgoehrig commented Oct 2, 2024

Since ESLint v8.x reaches end of life this weekend, it's time for us to start work on updating to v9.

This is currently blocked waiting on two dependencies to update:

So far I've only tested these changes in itwinjs-core.

We will also need to decide what to do about stylistic rules - these have moved out of typescript-eslint to @stylistic/eslint-plugin-ts, but the stylistic rules overall are discouraged by typescript-eslint. We may want to consider prettier or dprint...

@wgoehrig wgoehrig changed the title Update to ESLint 9.11 and typescript-eslint 8.8 Update to ESLint 9.11 and typescript-eslint 8.11 Oct 22, 2024
@wgoehrig wgoehrig marked this pull request as ready for review October 22, 2024 20:37
Copy link
Member

@aruniverse aruniverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but missing beachball changes
i assume this should be a new major ver of this pkg, and wed want to start off with pre-releases?

@wgoehrig
Copy link
Member Author

lgtm, but missing beachball changes i assume this should be a new major ver of this pkg, and wed want to start off with pre-releases?

Just added the beachball changes, but might need some help w/ publishing pre-releases if you all think those are necessary...

@ben-polinsky
Copy link
Collaborator

lgtm, but missing beachball changes i assume this should be a new major ver of this pkg, and wed want to start off with pre-releases?

Just added the beachball changes, but might need some help w/ publishing pre-releases if you all think those are necessary...

Just a GH action to trigger, I can do it after merge.

@wgoehrig wgoehrig merged commit aa162bb into main Oct 23, 2024
3 checks passed
@wgoehrig wgoehrig deleted the wbg/eslint9 branch October 23, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants