Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future: Scoped sizing using Context #969

Open
Tracked by #1226
FlyersPh9 opened this issue Jan 9, 2023 · 5 comments
Open
Tracked by #1226

Future: Scoped sizing using Context #969

FlyersPh9 opened this issue Jan 9, 2023 · 5 comments
Labels
enhancement New feature or request react Needs change in react package

Comments

@FlyersPh9
Copy link
Collaborator

FlyersPh9 commented Jan 9, 2023

Add the ability to set size on the entire page & all components match. Unsure if this will be a breaking change or not.

@FlyersPh9 FlyersPh9 added enhancement New feature or request react Needs change in react package labels Jan 9, 2023
@mayank99 mayank99 mentioned this issue Apr 20, 2023
22 tasks
@mayank99 mayank99 added this to the React 3.0 milestone May 4, 2023
@mayank99 mayank99 changed the title Context provider for size in iTwinUI-react v3: Scoped sizing using Context May 4, 2023
@gretanausedaite gretanausedaite removed this from the React 3.0 milestone Aug 28, 2023
@gretanausedaite gretanausedaite changed the title v3: Scoped sizing using Context Future: Scoped sizing using Context Aug 28, 2023
@GerardasB
Copy link

It might be useful to display elements in a container component consistently. I.e. a toolbar component defines the size, every toolbar item is rendered with the same size.

@FlyersPh9
Copy link
Collaborator Author

From our iTwinUI community meeting:

localize “Loading.” text in progress indicator

@veekeys

@veekeys
Copy link
Member

veekeys commented Feb 20, 2024

From our iTwinUI community meeting:

localize “Loading.” text in progress indicator

@veekeys

Probably not only in progress indicator. Can review all the "visually hidden" strings throughout the components.
Next stage would be thinking if extracting all localisable strings into single place would make sense? (I am not sure yet about this one, especially how this would be setup in multiple packages using iTwinUI)

@veekeys
Copy link
Member

veekeys commented Feb 21, 2024

I had one more thought on this..
Actually, if there are strings which should be just localised (same word kept, just different language), those should be localised in iTwinUI itself. That way it could be handled from centralised place rather than each product localising same string all over again.
I am not sure now if there are strings in iTwinUI, which could be changed?
Datepicker: for sure only localisation
Loading: I guess also just localisation?
Close icons: Localisation

Need to review cases with hardcoded strings.
That would mean adding some library (react-i18next) and then preparing the library for localisation (moving strings to separate file). And then in case there is any product requiring some language, iTwinUI would need to work with localisation team on this (probably some integration of process in github might be a challenge... )

@mayank99
Copy link
Contributor

That would mean adding some library (react-i18next) and then preparing the library for localisation (moving strings to separate file). And then in case there is any product requiring some language, iTwinUI would need to work with localisation team on this (probably some integration of process in github might be a challenge... )

Is there a defacto library that is used across all applications?

I don't think we should add a dependency on a specific i18n library. The design system should be compatible with whatever library the application prefers to use. If we add a dependency on one i18n library and the application uses another, it could technically still work but would cause unnecessary duplication in the client JS bundle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request react Needs change in react package
Projects
None yet
Development

No branches or pull requests

5 participants