feat(SearchBox): Add Search Box #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
gretanausedaite
force-pushed
the
greta/search-box
branch
from
c34bd69 to
ffcf724
Compare
gretanausedaite
force-pushed
the
greta/search-box
branch
from
460bf60 to
df4353c
Compare
gretanausedaite
force-pushed
the
greta/search-box
branch
from
3d3efb7 to
568eca4
Compare
mayank99
reviewed
May 9, 2023
packages/itwinui-react/src/core/utils/components/InputFlexContainer.tsx
Outdated
Show resolved
Hide resolved
mayank99
reviewed
May 9, 2023
|
|
||
| return ( | ||
| <Icon | ||
| aria-hidden | ||
| className={cx('iui-search-icon', className)} | ||
| size={sizeContext} |
There was a problem hiding this comment.
is this intentional?
| Before | Now |
|---|---|
 |
 |
edit: Greta said it is to match borderless button which uses 16x16 icon even with small size
Co-authored-by: Greta <[email protected]>
Co-authored-by: Greta <[email protected]>
Co-authored-by: Greta <[email protected]>
elephantcatdog
approved these changes
May 9, 2023
| * Id to pass to input | ||
| */ | ||
| inputId: string; | ||
| setInputId: (inputId: string) => void; |
There was a problem hiding this comment.
setInputId is missing a comment
There was a problem hiding this comment.
It is for context so internal use only.
Added comment.
| <Divider orientation='vertical' /> | ||
| <SearchBox.CollapseButton /> | ||
| </SearchBox.ExpandedState> | ||
| </SearchBox> |
There was a problem hiding this comment.
The composition looks nice in use : )
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
CSS
React
Testing
Documentation