Toaster: make closeAll
function async
to allow await
ing it
#1025
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Instead of hoping that promises resolve correctly, users can now
await
close calls to our toaster before opening other toasts.Does it fix #1005? Does it break anything? Lets find out!!
Edit: It does break things. I'll figure out a different approach. Stay tuned.
Edit 2: Fixed failing tests by not
await
ing creation functions. See #1025 (comment).Testing
Pending.
Docs
Pending