-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Temporary placeholders for unfinished pages on doc website #1099
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good idea!
Maybe we could add some kind of banner/alert instead of simple text? You could create a component and pass down all mdx pages that need this info. Also, you could create new styling for this component, it doesn't have to be iTwinUI - you can use our theme gradients or something.
Agreed with @gretanausedaite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<span class='iui-alert-message' | ||
>Some pages have not yet been finished and are being worked on. In the meantime, visit <a | ||
class='iui-alert-link' | ||
href='https://itwin.github.io/iTwinUI/react/?path=/story/overview--page'>storybook</a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be cool if we routed users to same component in storybook. Can be added later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
I think it might be better to control this message at a page-level rather than adding to the grid on all pages. This will also allow customizing the message/link for each page. The implementation could look like one of these two options:
|
Thank you both for your input! I've updated the placeholder. Now it's got a property for the end of the storybook url, and is placed on an individual component's page vs the layout. I did it this way because the end of the urls vary a bit. I also updated the visuals to something similar to what you showed, Greta, because I thought that looked nice. If this looks good, then I'll put the placeholder on all the pages that need it. I have it on 'Avatar' and 'Carousel' right now (and will remove it from 'Avatar'). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
usage looks good so i think it can be added to all pages as-is, but i think the styling could be toned down to be less distracting.
i also wonder if the note should come before or after the component description. probably after? because the description is closely connected with the heading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Agree with using variables instead of hardcoding hex.
Would it be possible to get rid of any CONNECT related references in public docs site? I do understand initially we might have copied some of the old content, but in this particular case (hopefully not that many in all docs site) it is something we do not want to even mention to anyone anymore. |
Agreed we should remove that. Almost every single page had content copied over from the old docs, so there might be more weird stuff. #961 is tracking the status of pages that have been further reviewed/adjusted after the old content was moved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once this comment is resolved, looks good to me!
Okay, I added the placeholder to all the unfinished pages, and confirmed that the links go where they're supposed to. I have a question about one of the pages though - 'Typography' is a page that has 'text' and 'label' on it, but we have separate pages for the other types of typography. Why does this page exist as it is, and not either include all types of typography or have separate pages for all? |
What are "other types of typography"? |
Hm, I see, thanks Greta |
Changes
I thought it would be helpful to have placeholders for unfinished pages on the doc website so that people going here or being redirected here from ux.bentley.com aren't only getting a bunch of mostly empty pages with little information on them.
I want to add it to all the unfinished pages, but wanted to see if this format/wording is good before copy/pasting to all the other pages. I added the lines before and after so that it's a bit more noticeable. Also I'm not sure if it's better to have the full link be visible vs just having 'storybook' with a link.
Testing
N/A
Docs
N/A