website: Buttons documentation update #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gretanausedaite
requested review from
a team,
mayank99 and
adamhock
and removed request for
a team
gretanausedaite
changed the title
68 tasks
mayank99
reviewed
Mar 27, 2023
FlyersPh9
reviewed
Mar 27, 2023
FlyersPh9
reviewed
Mar 27, 2023
FlyersPh9
reviewed
Mar 27, 2023
FlyersPh9
reviewed
Mar 27, 2023
FlyersPh9
approved these changes
Mar 28, 2023
adamhock
reviewed
Mar 28, 2023
| The borderless button is useful in tighter areas where using a default button would visibly cause too many boxes. | ||
|
|
||
| The borderless button is often used by actionable icons in relation to another component. | ||
| They are commonly used within [table](table) rows and widgets. A good example would be the close icon within a modal, toast notification, or alert. |
There was a problem hiding this comment.
Should there be links to Modal, Toast, and Alert pages?
There was a problem hiding this comment.
Removed this part as we are handling close buttons for the user.
Co-authored-by: adamhock <[email protected]>
Co-authored-by: adamhock <[email protected]>
Co-authored-by: adamhock <[email protected]>
Co-authored-by: adamhock <[email protected]>
Co-authored-by: adamhock <[email protected]>
adamhock
approved these changes
Mar 29, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updated documentation of buttons.
Button part of #961
Testing
N/A
Docs
N/A