Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: Textarea #1178

Merged
merged 10 commits into from
Apr 7, 2023
Merged

website: Textarea #1178

merged 10 commits into from
Apr 7, 2023

Conversation

gretanausedaite
Copy link
Contributor

Changes

Textarea of #961

Testing

N/A

Docs

N/A

@gretanausedaite gretanausedaite requested a review from a team as a code owner March 31, 2023 08:31
@gretanausedaite gretanausedaite requested review from a team, FlyersPh9 and elephantcatdog and removed request for a team March 31, 2023 08:31
@FlyersPh9
Copy link
Collaborator

Why does the resize handle / scrollbar look so different between the docs site vs. the Storybook & HTML demo?

HTML demo:
Screenshot 2023-03-31 at 2 19 59 PM

Storybook:
Screenshot 2023-03-31 at 2 22 13 PM

Docs site:
Screenshot 2023-03-31 at 2 20 07 PM

@FlyersPh9 FlyersPh9 mentioned this pull request Mar 31, 2023
21 tasks
Copy link
Contributor

@elephantcatdog elephantcatdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some places "textarea" is used and in others "text area" is used. I think we should do it the same way throughout the page. I prefer with the space, but whatever is the right way if that's already set.

apps/website/src/pages/docs/textarea.mdx Outdated Show resolved Hide resolved
apps/website/src/pages/docs/textarea.mdx Outdated Show resolved Hide resolved
apps/website/src/pages/docs/textarea.mdx Outdated Show resolved Hide resolved
apps/website/src/pages/docs/textarea.mdx Outdated Show resolved Hide resolved
apps/website/src/examples/Textarea.scroll.tsx Outdated Show resolved Hide resolved
@FlyersPh9 FlyersPh9 added the documentation Improvements or additions to documentation label Mar 31, 2023
@gretanausedaite
Copy link
Contributor Author

Why does the resize handle / scrollbar look so different between the docs site vs. the Storybook & HTML demo?

Maybe we are overriding scrollbar width somewhere in the app. It looks wider everywhere. Added an issue in #941

<AllExamples.TextareaStatusExample client:load />
</LiveExample>

If status messages are required, the styling is similar to [inputs](input). For the default textarea, the bottom border gains the color of the alert level, as well as the corresponding icon and message.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is just a reminder about "textarea" vs "text area".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated "textarea" to be "text area"

Copy link
Contributor

@elephantcatdog elephantcatdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the title and thumbnail (lines 2 & 6 of textarea.mdx) be "Text area"?

@gretanausedaite
Copy link
Contributor Author

Should the title and thumbnail (lines 2 & 6 of textarea.mdx) be "Text area"?

Thumbnail "TextArea" is the name of the image. Will not change that.
Title Textarea matches our component name - leaving that as well.

@mayank99
Copy link
Contributor

mayank99 commented Apr 6, 2023

fyi, "textarea" is the canonical name, all one word. you can see the MDN docs on textarea, it does not use "text area" or "TextArea" anywhere.

Copy link
Contributor

@elephantcatdog elephantcatdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi, "textarea" is the canonical name, all one word. you can see the MDN docs on textarea, it does not use "text area" or "TextArea" anywhere.

I didn't know this. Greta, if you think it's better to have the text be "textarea" that's fine with me. I mostly just wanted it to be consistent.

@gretanausedaite gretanausedaite added this pull request to the merge queue Apr 7, 2023
Merged via the queue into main with commit 846abdc Apr 7, 2023
@gretanausedaite gretanausedaite deleted the greta/text-area branch April 7, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants