Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve website typography #1193

Merged
merged 1 commit into from
Apr 7, 2023
Merged

improve website typography #1193

merged 1 commit into from
Apr 7, 2023

Conversation

mayank99
Copy link
Contributor

@mayank99 mayank99 commented Apr 7, 2023

Changes

  • Increased the spacing between sections by using a slightly larger value and by using em instead of rem.
  • Fixed the colors so that heading text looks brighter than paragraph text.
  • Updated the heading font size to use the fluid typography scale that we already have in place.

All of these changes help address #941 (comment)

Testing

Tested locally.

Docs

N/A

@mayank99 mayank99 requested a review from a team as a code owner April 7, 2023 16:10
@mayank99 mayank99 requested review from a team, gretanausedaite and elephantcatdog and removed request for a team April 7, 2023 16:10
@mayank99 mayank99 self-assigned this Apr 7, 2023
@mayank99 mayank99 requested a review from FlyersPh9 April 7, 2023 16:10
elephantcatdog
elephantcatdog approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@elephantcatdog elephantcatdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mayank99 mayank99 added this pull request to the merge queue Apr 7, 2023
Merged via the queue into main with commit 3558778 Apr 7, 2023
@mayank99 mayank99 deleted the mayank/fix-website-typography branch April 7, 2023 19:20
@mayank99 mayank99 mentioned this pull request Jul 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elephantcatdog elephantcatdog elephantcatdog approved these changes

@FlyersPh9 FlyersPh9 FlyersPh9 approved these changes

@gretanausedaite gretanausedaite Awaiting requested review from gretanausedaite gretanausedaite was automatically assigned from iTwin/itwinui-css-1

Assignees

@mayank99 mayank99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mayank99 @FlyersPh9 @elephantcatdog