Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Popover controlled mode during first render #1276

Merged
merged 2 commits into from
May 15, 2023
Merged

fix Popover controlled mode during first render #1276

merged 2 commits into from
May 15, 2023

Conversation

mayank99
Copy link
Contributor

Changes

Ported from #1265 (comment) for release in v2. It could fix some of the issues with our Popover.

Testing

Fixes the weird edge cases that I was facing in #1265, and doesn't cause any existing tests to break, which is good.

Docs

N/A

@mayank99 mayank99 self-assigned this May 12, 2023
@mayank99 mayank99 requested a review from a team as a code owner May 12, 2023 16:29
@mayank99 mayank99 requested review from a team, gretanausedaite and LostABike and removed request for a team May 12, 2023 16:29
@mayank99
Copy link
Contributor Author

This could maybe help with iTwin/appui#271 (unsure).

LostABike
LostABike approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@LostABike LostABike left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same change in #1265 , wouldn't that just override it?

@mayank99
Copy link
Contributor Author

mayank99 commented May 12, 2023 •
edited
Loading

This is the same change in #1265 , wouldn't that just override it?

This PR is meant to be released in the next v2 version (#1250), whereas #1265 is a breaking change that won't be released until v3 (a few months from now).

gretanausedaite
gretanausedaite approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@gretanausedaite gretanausedaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/itwinui-react/src/core/utils/components/Popover.tsx Outdated Show resolved Hide resolved
@mayank99 mayank99 added this pull request to the merge queue May 15, 2023
Merged via the queue into main with commit 5cfd0bb May 15, 2023
@mayank99 mayank99 deleted the mayank/popover-visible-fix branch May 15, 2023 13:57
@imodeljs-admin imodeljs-admin mentioned this pull request May 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gretanausedaite gretanausedaite gretanausedaite approved these changes

@LostABike LostABike LostABike approved these changes

Assignees

@mayank99 mayank99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mayank99 @LostABike @gretanausedaite