wrap all website examples in ThemeProvider #1353
Conversation
mayank99
requested review from
gretanausedaite and
LostABike
and removed request for
a team
There was a problem hiding this comment.
I think this search bar is supposed to be longer? (the rest of the bars in the SearchBox doc are also short)
Or did we update all input boxes to have a smaller size at some point? 🤔
|
@LostABike I've fixed the styles issue. It was because there was an additional wrapper element. It's a bit hacky but works. We'll need to find a more robust solution in the future. The problem was that #1300 introduced an extra |
|
|
||
| export { default as VisuallyHiddenIconExample } from './VisuallyHidden.icon'; | ||
| export { default as VisuallyHiddenMoreTextExample } from './VisuallyHidden.moretext'; | ||
| import * as React from 'react'; |
There was a problem hiding this comment.
That's a lot of lines 👀
There was a problem hiding this comment.
yeah, but it's a lot fewer lines than adding <ThemeProvider></ThemeProvider> manually to every single example usage - especially when you consider that we will start using examples in other places (like #1352)
Good catch, but this means context is actually working now (previously it portaled into |
Changes
What I did: Changed
examples/index.tsxso that all exports are wrapped in<ThemeProvider>using a HOCwithThemeProvider. Also some examples were using (nonexistent)args, so removed those too.Why: In #1351, toasts were not working on website because context was not being found somehow. I figured out it's because context doesn't work in Astro between islands. (Previously,
ThemeProviderand the examples were rendered in separate islands). Within the same island, context works fine.Testing
Tested against #1351 and toasts are now correctly showing up!
Screen.Recording.2023-06-13.at.3.45.04.PM.mov
Docs
N/A