-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring failing Avatar examples to a11y compliance #1397
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank99
reviewed
Jul 10, 2023
…n/iTwinUI into xander/avatar-a11y-examples
mayank99
reviewed
Jul 10, 2023
Co-authored-by: Mayank <[email protected]>
Co-authored-by: Mayank <[email protected]>
mayank99
approved these changes
Jul 10, 2023
FlyersPh9
approved these changes
Jul 10, 2023
LostABike
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Merged
23 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a11y
Accessibility issues (keyboard navigation, color contrast, assistive technologies, semantics, etc)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Editing the
Avatar
examples that are violating a11y rules to make them compliant. Component-level changes may be needed.Addresses issue 1148.
Testing
Accessibility tested thru Cypress a11y tests. Unit and visual tests run as well.
Docs
N/A