button group a11y compliance #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xman343
added
the
a11y
…tton-group-a11y
xman343
requested review from
mayank99 and
adamhock
and removed request for
a team
mayank99
reviewed
Jul 17, 2023
Co-authored-by: Mayank <[email protected]>
mayank99
approved these changes
Jul 17, 2023
adamhock
approved these changes
Jul 17, 2023
| '@itwin/itwinui-react': patch | ||
| --- | ||
|
|
||
| `aria-orientation` attribute removed from ButtonGroup to meet accessibility requirements. |
There was a problem hiding this comment.
I would mention this in the PR description
Merged
23 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Bringing
ButtonGroupexamples to a11y compliance.ButtonGroupcomponent brought to compliance by removingaria-orientationattribute .Addresses #1148
Testing
Unit testing & visual testing will be conducted.
Docs
N/A