Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combobox a11y fix #1456

Merged
merged 18 commits into from
Aug 2, 2023
Merged

Combobox a11y fix #1456

merged 18 commits into from
Aug 2, 2023

Conversation

xman343
Copy link
Contributor

@xman343 xman343 commented Jul 28, 2023 •
edited
Loading

Changes

#1148 - Added aria-label to ComboBoxInput so that the component can meet a11y standards.

Testing

A11y tests conducted.

Docs

N/A

@xman343 xman343 self-assigned this Jul 28, 2023
@xman343 xman343 added the a11y Accessibility issues (keyboard navigation, color contrast, assistive technologies, semantics, etc) label Jul 28, 2023
@xman343 xman343 marked this pull request as ready for review July 28, 2023 19:32
@xman343 xman343 requested review from a team as code owners July 28, 2023 19:32
@xman343 xman343 requested review from gretanausedaite and adamhock and removed request for a team July 28, 2023 19:32
mayank99
mayank99 approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@mayank99 mayank99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Will need to update docs in a separate PR to emphasize that labels should always be used.

@xman343 xman343 added this pull request to the merge queue Aug 2, 2023
Merged via the queue into dev with commit 1533cd0 Aug 2, 2023
@xman343 xman343 deleted the xander/combobox-examples-a11y-fix branch August 2, 2023 18:22
@xman343 xman343 mentioned this pull request Aug 4, 2023
Open
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gretanausedaite gretanausedaite gretanausedaite left review comments

@adamhock adamhock adamhock approved these changes

@mayank99 mayank99 mayank99 approved these changes

Assignees

@xman343 xman343

Labels
a11y Accessibility issues (keyboard navigation, color contrast, assistive technologies, semantics, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xman343 @mayank99 @adamhock @gretanausedaite