-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Header a11y fix #1495
Merged
Merged
Header a11y fix #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xman343
added
the
a11y
Accessibility issues (keyboard navigation, color contrast, assistive technologies, semantics, etc)
label
Aug 15, 2023
23 tasks
This reverts commit 7ddf5e6.
Conflicted on whether to implement the accessible name through |
xman343
requested review from
gretanausedaite and
siddhantrawal
and removed request for
a team
August 16, 2023 19:44
mayank99
reviewed
Aug 16, 2023
Co-authored-by: Mayank <[email protected]>
mayank99
reviewed
Aug 16, 2023
Co-authored-by: Mayank <[email protected]>
mayank99
approved these changes
Aug 16, 2023
siddhantrawal
approved these changes
Aug 16, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a11y
Accessibility issues (keyboard navigation, color contrast, assistive technologies, semantics, etc)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
#1148 - The only example
Main
is currently failing. This is due to the lack of an accessible label for theHeaderSplitButton
.aria-label
"More" forHeaderSplitButton
. This helps the screen reader communicate the purpose of the button to the user.Testing
Testing will be conducted through the Cypress web a11y script. Any breaking changes will be evaluated through unit testing & visual tests. Example also read through NVDA to assess screen reader compatibility.
Docs
TBD