Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header a11y fix #1495

Merged
merged 20 commits into from
Aug 21, 2023
Merged

Header a11y fix #1495

merged 20 commits into from
Aug 21, 2023

Conversation

xman343
Copy link
Contributor

@xman343 xman343 commented Aug 15, 2023

Changes

#1148 - The only example Main is currently failing. This is due to the lack of an accessible label for the HeaderSplitButton.

  • Passing solution: Implemented aria-label "More" for HeaderSplitButton. This helps the screen reader communicate the purpose of the button to the user.

Testing

Testing will be conducted through the Cypress web a11y script. Any breaking changes will be evaluated through unit testing & visual tests. Example also read through NVDA to assess screen reader compatibility.

Docs

TBD

@xman343 xman343 added the a11y Accessibility issues (keyboard navigation, color contrast, assistive technologies, semantics, etc) label Aug 15, 2023
@xman343 xman343 self-assigned this Aug 15, 2023
@xman343 xman343 changed the title Xander header a11y fix Header a11y fix Aug 15, 2023
@xman343
Copy link
Contributor Author

xman343 commented Aug 16, 2023

Conflicted on whether to implement the accessible name through VisuallyHidden or a title for the button. I'm going with title for now since it serves the extra function of displaying the label in a popover when it's hovered on. I could change it if we decide that it's unnecessary for this component.

@xman343 xman343 marked this pull request as ready for review August 16, 2023 19:44
@xman343 xman343 requested review from a team as code owners August 16, 2023 19:44
@xman343 xman343 requested review from gretanausedaite and siddhantrawal and removed request for a team August 16, 2023 19:44
@mayank99 mayank99 merged commit ccb3040 into dev Aug 21, 2023
@mayank99 mayank99 deleted the xander-header-a11y-fix branch August 21, 2023 13:16
@imodeljs-admin imodeljs-admin mentioned this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility issues (keyboard navigation, color contrast, assistive technologies, semantics, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants