Typecasting forwardRef inside Select
#1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddhantrawal
changed the title
forwardRef inside Select
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
siddhantrawal
requested review from
mayank99 and
r100-stack
and removed request for
a team
mayank99
reviewed
Jan 9, 2024
r100-stack
reviewed
Jan 9, 2024
There was a problem hiding this comment.
No additional comments. Just found this StackOverflow answer that might be related.
r100-stack
reviewed
Jan 9, 2024
mayank99
reviewed
Jan 10, 2024
Is it okay to have a new PR for it or should I have it included in this one? |
r100-stack
reviewed
Jan 10, 2024
mayank99
reviewed
Jan 10, 2024
mayank99
approved these changes
Jan 11, 2024
r100-stack
reviewed
Jan 11, 2024
packages/itwinui-react/src/core/LabeledSelect/LabeledSelect.types-test.tsx
Show resolved
Hide resolved
Is the changeset okay? (9c481a7). |
r100-stack
reviewed
Jan 11, 2024
packages/itwinui-react/src/core/LabeledSelect/LabeledSelect.types-test.tsx
Outdated
Show resolved
Hide resolved
mayank99
reviewed
Jan 11, 2024
Co-authored-by: Mayank <[email protected]>
r100-stack
approved these changes
Jan 11, 2024
mayank99
reviewed
Jan 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes: #1767
Added type for forwardRef inside
SelectandLabeledSelectcomponent (Refer to option 1 inside this link).Added Type checking test case for both components.
Added unit test that forwards the ref Inside the components.
For reviewing, turn off whitespace diff.
Testing
Tested locally in the Vite Playground. No longer getting the error mentioned in #1767.
Docs
Added changeset.