NotificationMarker docs page
#1999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r100-stack
requested review from
mayank99 and
Ben-Pusey-Bentley
and removed request for
a team
mayank99
reviewed
Apr 16, 2024
|
|
||
| ### Status | ||
|
|
||
| `NotificationMarker`s can have `primary` (default), `positive`, `warning`, `negative`, or `white` statuses. The `white` status is used on colored backgrounds, such as when using it in the [high visibility](button#high-visibility) or the [call-to-action](button#call-to-action) buttons. |
There was a problem hiding this comment.
(Unrelated) This is making me realize that we should handle the primary vs white statuses by default when used in Button. The user shouldn't need to think about the difference.
mayank99
reviewed
Apr 17, 2024
mayank99
reviewed
Apr 17, 2024
Co-authored-by: Mayank <[email protected]>
mayank99
reviewed
Apr 17, 2024
Ben-Pusey-Bentley
approved these changes
Apr 17, 2024
mayank99
approved these changes
Apr 17, 2024
68 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds a page to the docs site for the
NotificationMarkercomponent.It also makes a few nitpick changes in other docs files to try to have a consistent format across all docs pages.
Testing
N/A
Docs
N/A