simplify types generation using a single tsconfig #2118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank99
requested review from
r100-stack and
Ben-Pusey-Bentley
and removed request for
a team
Ben-Pusey-Bentley
approved these changes
Jun 26, 2024
r100-stack
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is a follow-up to #2100 and precursor to #2119.
The
"module"has been changed to"NodeNext"because newer TS versions require it if also using"moduleResolution": "NodeNext"(see 5.2 release notes).The
tsconfig.esm,tsconfig.cjsandtsconfig.react-tablefiles have all been removed. A singletsconfig.buildis used for generating all types.tsconfig.esmandtsconfig.cjsare not necessary because the actual JS output is generated byswc. The types have always been identical between esm and cjs, so a single config can be used, with--outDirpassed inline through CLI args.tsconfig.react-tablewas only used to generate a top-levelreact-table.d.tsfile (see original comment and related recent PR for more context). This file has now been removed, and the fallback strategy is now implemented usingtypesVersions, based on this SO answer and this repo.Testing
Build passing, and verified that the build output looks fine.
Manually verified that vite-playground errors out using
"moduleResolution": "Node"only when the"typesVersions"is not present in@itwin/itwinui-react/package.json.Docs
Added changesets.