create FieldsetBase component
#2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
mayank99
requested review from
r100-stack and
Ben-Pusey-Bentley
and removed request for
a team
Ben-Pusey-Bentley
approved these changes
Jul 9, 2024
r100-stack
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
<fieldset>styles.FieldsetBasecomponent that uses this new class.Fieldsetcomponent to use this new component as a base.The
FieldsetBasecomponent will be useful in other places (e.g. #2135) where we should use<fieldset>but feel limited by its default styles. In the future, we could potentially even expose this as a public component with some docs and improvements.Testing
N/A. This is just moving things around so everything works the same.
Docs
Added CSS changeset since the new class is part of the public API and requires a breaking change.
Added light jsdocs. No React changeset needed, as this shouldn't affect anyone.