Created documentation for SkipToContentLink
#2326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68 tasks
smmr-dn
commented
Nov 5, 2024
There was a problem hiding this comment.
The examples are currently not working since the page uses the "#" identifier to move focus to its section (e.g. Usage, Props, ...) but not the actual div that contains the main content's id, which causes the page not focusing on the main content of each example. I notice the v2 storybook opens the links in new tab so maybe we can do something similar for this doc? Other than that, I'm not sure how I should handle the examples.
smmr-dn
requested review from
mayank99 and
r100-stack
and removed request for
a team
mayank99
reviewed
Nov 6, 2024
r100-stack
approved these changes
Nov 6, 2024
mayank99
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Created documentation for the
SkipToContentLinkcomponent. Further improvement will be done for this documentation.Testing
N/A
Docs
N/A
After-PR TODO:
SkipToContentLink#2326 (comment)). Resolved in Allowed hiding demo code inLiveExample#2350