-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added buffer to all sides of Tooltip
's floating content
#2359
Conversation
There are two things I would like to ask for more opinions in this PR:
safePolygon-removed.mp4
|
If it doesn't behave properly without
Yeah that's fine. I'm not sure why we even had |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and nice work! Just make sure to add a changeset.
Changes
This PR added a buffer of 4px to all sides of the
Tooltip
's floating content so that when users slightly move their mouse outside of the content box, the tooltip is still visible.Testing
Confirmed that the tooltip is still visible when the mouse moves outside of the border.
buffered-tooltip.mp4
Docs
Added patch changeset.