-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduced default ToggleSwitch
's height to 24px
#2363
Closed
Closed
Changes from 6 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
5f5125c
reduced toggle switch height
smmr-dn d9743d5
set vertical margins to auto
smmr-dn 8717311
added screenshots
smmr-dn 9cfb459
added changesets
smmr-dn 6a86dfe
Merge branch 'main' into uyen/toggle-height
smmr-dn 45811df
Merge branch 'main' into uyen/toggle-height
smmr-dn c1fdfd1
Merge branch 'main' into uyen/toggle-height
smmr-dn e18ae6c
fixed calculation to make default Toggle 46px in width
smmr-dn f10a1be
revert screenshots
smmr-dn d706b97
Merge branch 'uyen/toggle-height' of https://github.com/iTwin/iTwinUI…
smmr-dn 42295df
moved vars around
smmr-dn f6d7542
reset margins for small toggle
smmr-dn 0fe0122
modified changesets
smmr-dn 45862f1
css-workshop screenshots
smmr-dn 5026903
screenshots
smmr-dn b8ac286
Update tough-readers-reflect.md
smmr-dn 66bf100
revert screenshots
smmr-dn d6d5d91
Merge branch 'uyen/toggle-height' of https://github.com/iTwin/iTwinUI…
smmr-dn 786c249
revert some margins
smmr-dn b49c025
misc fixes
smmr-dn 8c02302
Merge branch 'main' into uyen/toggle-height
smmr-dn 16db057
fixed sreenshots containing small toggle
smmr-dn 5889cbc
centered
smmr-dn 2f5a850
revert screenshots
smmr-dn d628c27
revert App.tsx
smmr-dn 2722b9a
react screenshots
smmr-dn a67f57d
Merge branch 'main' into uyen/toggle-height
smmr-dn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@itwin/itwinui-react': patch | ||
--- | ||
|
||
`ToggleSwitch` now has the height of 24px instead of 26px. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@itwin/itwinui-css': patch | ||
--- | ||
|
||
`iui-toggle-switch` now has the height of 24px. | ||
Binary file modified
BIN
-111 Bytes
(99%)
...reference/iTwinUI_column-filter_Type_Date_filter_dark_0_demo-date_0_desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-111 Bytes
(99%)
...erence/iTwinUI_column-filter_Type_Date_filter_hc_dark_0_demo-date_0_desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-145 Bytes
(99%)
...rence/iTwinUI_column-filter_Type_Date_filter_hc_light_0_demo-date_0_desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-189 Bytes
(99%)
...eference/iTwinUI_column-filter_Type_Date_filter_light_0_demo-date_0_desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-250 Bytes
(99%)
...tmaps_reference/iTwinUI_fieldset_Type_Default_dark_0_demo-default_0_desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-328 Bytes
(99%)
...ps_reference/iTwinUI_fieldset_Type_Default_hc_dark_0_demo-default_0_desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-558 Bytes
(98%)
...s_reference/iTwinUI_fieldset_Type_Default_hc_light_0_demo-default_0_desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-321 Bytes
(99%)
...maps_reference/iTwinUI_fieldset_Type_Default_light_0_demo-default_0_desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-253 Bytes
(99%)
...e-switch_State_focus_checked__hover_unchecked_dark_0_demo-default_0_desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-482 Bytes
(98%)
...witch_State_focus_checked__hover_unchecked_hc_dark_0_demo-default_0_desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-228 Bytes
(99%)
...itch_State_focus_checked__hover_unchecked_hc_light_0_demo-default_0_desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-379 Bytes
(98%)
...-switch_State_focus_checked__hover_unchecked_light_0_demo-default_0_desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-233 Bytes
(99%)
...e-switch_State_hover_checked__focus_unchecked_dark_0_demo-default_0_desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-471 Bytes
(98%)
...witch_State_hover_checked__focus_unchecked_hc_dark_0_demo-default_0_desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-192 Bytes
(99%)
...itch_State_hover_checked__focus_unchecked_hc_light_0_demo-default_0_desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-358 Bytes
(98%)
...-switch_State_hover_checked__focus_unchecked_light_0_demo-default_0_desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-245 Bytes
(99%)
..._reference/iTwinUI_toggle-switch_Type_Default_dark_0_demo-default_0_desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-423 Bytes
(98%)
...ference/iTwinUI_toggle-switch_Type_Default_hc_dark_0_demo-default_0_desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-123 Bytes
(99%)
...erence/iTwinUI_toggle-switch_Type_Default_hc_light_0_demo-default_0_desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-348 Bytes
(98%)
...reference/iTwinUI_toggle-switch_Type_Default_light_0_demo-default_0_desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-57 Bytes
(99%)
...maps_reference/iTwinUI_toggle-switch_Type_Small_dark_0_demo-small_0_desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-23 Bytes
(100%)
...s_reference/iTwinUI_toggle-switch_Type_Small_hc_dark_0_demo-small_0_desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-108 Bytes
(99%)
..._reference/iTwinUI_toggle-switch_Type_Small_hc_light_0_demo-small_0_desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-86 Bytes
(99%)
...aps_reference/iTwinUI_toggle-switch_Type_Small_light_0_demo-small_0_desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-138 Bytes
(98%)
...ce/iTwinUI_toggle-switch_Type_label_left_dark_0_demo-toggle-right_0_desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-172 Bytes
(97%)
...iTwinUI_toggle-switch_Type_label_left_hc_dark_0_demo-toggle-right_0_desktop.png
Oops, something went wrong.
Binary file modified
BIN
-92 Bytes
(99%)
...TwinUI_toggle-switch_Type_label_left_hc_light_0_demo-toggle-right_0_desktop.png
Oops, something went wrong.
Binary file modified
BIN
-5 Bytes
(100%)
...e/iTwinUI_toggle-switch_Type_label_left_light_0_demo-toggle-right_0_desktop.png
Oops, something went wrong.
Binary file modified
BIN
-128 Bytes
(96%)
...iTwinUI_toggle-switch_Type_label_none_dark_0_demo-toggle-no-label_0_desktop.png
Oops, something went wrong.
Binary file modified
BIN
-122 Bytes
(96%)
...inUI_toggle-switch_Type_label_none_hc_dark_0_demo-toggle-no-label_0_desktop.png
Oops, something went wrong.
Binary file modified
BIN
-177 Bytes
(95%)
...nUI_toggle-switch_Type_label_none_hc_light_0_demo-toggle-no-label_0_desktop.png
Oops, something went wrong.
Binary file modified
BIN
-129 Bytes
(96%)
...TwinUI_toggle-switch_Type_label_none_light_0_demo-toggle-no-label_0_desktop.png
Oops, something went wrong.
Binary file modified
BIN
-169 Bytes
(97%)
...ce/iTwinUI_toggle-switch_Type_label_right_dark_0_demo-toggle-left_0_desktop.png
Oops, something went wrong.
Binary file modified
BIN
-128 Bytes
(98%)
...iTwinUI_toggle-switch_Type_label_right_hc_dark_0_demo-toggle-left_0_desktop.png
Oops, something went wrong.
Binary file modified
BIN
-122 Bytes
(98%)
...TwinUI_toggle-switch_Type_label_right_hc_light_0_demo-toggle-left_0_desktop.png
Oops, something went wrong.
Binary file modified
BIN
-32 Bytes
(99%)
...e/iTwinUI_toggle-switch_Type_label_right_light_0_demo-toggle-left_0_desktop.png
Oops, something went wrong.
Binary file modified
BIN
-167 Bytes
(99%)
apps/react-workshop/cypress-visual-screenshots/baseline/Fieldset.test.ts-Basic.png
Oops, something went wrong.
Binary file modified
BIN
-149 Bytes
(99%)
...eact-workshop/cypress-visual-screenshots/baseline/Fieldset.test.ts-Disabled.png
Oops, something went wrong.
Binary file modified
BIN
-190 Bytes
(99%)
...orkshop/cypress-visual-screenshots/baseline/InputGroup.test.ts-Toggle Group.png
Oops, something went wrong.
Binary file modified
BIN
-60 Bytes
(100%)
...orkshop/cypress-visual-screenshots/baseline/Panels.test.ts-Multi Level List.png
Oops, something went wrong.
Binary file modified
BIN
-62 Bytes
(99%)
...act-workshop/cypress-visual-screenshots/baseline/ToggleSwitch.test.ts-Basic.png
Oops, something went wrong.
Binary file modified
BIN
-88 Bytes
(99%)
...p/cypress-visual-screenshots/baseline/ToggleSwitch.test.ts-Disabled Checked.png
Oops, something went wrong.
Binary file modified
BIN
-79 Bytes
(99%)
...cypress-visual-screenshots/baseline/ToggleSwitch.test.ts-Disabled Unchecked.png
Oops, something went wrong.
Binary file modified
BIN
-38 Bytes
(100%)
...orkshop/cypress-visual-screenshots/baseline/ToggleSwitch.test.ts-Label Left.png
Oops, something went wrong.
Binary file modified
BIN
-74 Bytes
(99%)
...rkshop/cypress-visual-screenshots/baseline/ToggleSwitch.test.ts-Label Right.png
Oops, something went wrong.
Binary file modified
BIN
-90 Bytes
(98%)
...act-workshop/cypress-visual-screenshots/baseline/ToggleSwitch.test.ts-Small.png
Oops, something went wrong.
Binary file modified
BIN
-73 Bytes
(99%)
...p/cypress-visual-screenshots/baseline/ToggleSwitch.test.ts-With Custom Icon.png
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might need to mention which size is now
24px
, because there are multiple ToggleSwitch sizes.Same for the other changeset.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the changesets.