Add missing react imports in examples #2371
Open
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r100-stack
requested review from
mayank99 and
smmr-dn
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
@mayank99 noticed that when some examples (e.g.
Panels's examples) were opened in CodePen from the docs site, the following error is encountered:ReferenceError: React is not defined.To avoid this error in those examples, React imports are added to the examples that were missing it.
In the future, as @mayank99 suggested, we could even have a lint rule to easily ensure this react import is there.
Testing
Panelsexamples and the other examples that were missing the react import now open properly in CodePen.Docs
N/A
After PR TODOs