-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSMAP Read-only directory fix for itwinjs-backlog 1118 #761
base: main
Are you sure you want to change the base?
Conversation
Fix was suggested by Alain Robert
I will cherry-pick this into release/4.x once merged. |
@Mergifyio backport release/4.x |
🟠 Waiting for conditions to match
|
I have made all tests run correctly on a local build. The failing tests must be related to something in the pipeline. I also noted the presence of a few windows slashes in tests paths. I think these should be changed from \ to / specifically at:
|
As far as I can tell, BeFileName automatically fixes paths to be correct on Windows and non-Windows. (On Windows, it converts all forward slashes to backslashes, and on non-Windows, it converts all backslashes to forward slashes.) There are four total places in the GeoCoord C++ code that use |
Fix was suggested by Alain Robert
See https://github.com/iTwin/itwinjs-backlog/issues/1118#issuecomment-2115811221