Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSMAP Read-only directory fix for itwinjs-backlog 1118 #761

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tcobbs-bentley
Copy link
Member

@tcobbs-bentley
Copy link
Member Author

I will cherry-pick this into release/4.x once merged.

@aruniverse
Copy link
Member

@Mergifyio backport release/4.x

Copy link

mergify bot commented May 16, 2024

backport release/4.x

🟠 Waiting for conditions to match

  • merged [📌 backport requirement]

@AlainRobertAtBentley
Copy link
Contributor

I have made all tests run correctly on a local build. The failing tests must be related to something in the pipeline. I also noted the presence of a few windows slashes in tests paths. I think these should be changed from \ to / specifically at:

path.AppendToPath(L"Assets\\DgnGeoCoord");

@tcobbs-bentley
Copy link
Member Author

I have made all tests run correctly on a local build. The failing tests must be related to something in the pipeline. I also noted the presence of a few windows slashes in tests paths. I think these should be changed from \ to / specifically at:

path.AppendToPath(L"Assets\\DgnGeoCoord");

As far as I can tell, BeFileName automatically fixes paths to be correct on Windows and non-Windows. (On Windows, it converts all forward slashes to backslashes, and on non-Windows, it converts all backslashes to forward slashes.) There are four total places in the GeoCoord C++ code that use Assets\\, and none that use Assets/, so it seems like leaving it alone is the best thing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants