Wrong property tags issue #970
Draft
+145
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng property tags across various versions
| @@ -44,6 +44,11 @@ SchemaReadStatus ReadTypeNameWithPruning(pugi::xml_node node, ECPropertyP prop, | |||
| // must come after prune check to make sure we don't default to string properties that should be pruned | |||
| if (setTypeStatus == ECObjectsStatus::ParseError && ignoreParseErrors) | |||
| { | |||
| // Unknown type encounter in the schema for the current version returning ERROR status | |||
| if (!(prop->GetClass().GetSchema().OriginalECXmlVersionGreaterThan(ECVersion::Latest)) && !(prop->GetClass().GetSchema().OriginalECXmlVersionLessThan(ECVersion::Latest))) | |||
There was a problem hiding this comment.
Why not just check for ECVersion::Latest ?
|
|
| ASSERT_EQ(deserializationStatus, schema.IsValid()) << "Test case number: " << testCaseNumber << " failed due to invalid schemas."; | ||
|
|
||
| // Checking if the wrong property tags are defaulted to string type | ||
| if (testCaseNumber != 4) |
There was a problem hiding this comment.
It would be cleaner and more readable if you check deserializationStatus instead of the test case number.
| if (testCaseNumber == 5) | ||
| { | ||
| // Schema import should fail when ECXml version of the schema is greater than the current version that the ECDb supports | ||
| ASSERT_EQ(false, m_ecdb.Schemas().ImportSchemas(context->GetCache().GetSchemas()) == SchemaImportResult::OK) << "Test case number " << testCaseNumber << " failed since, the schema was imported."; |
There was a problem hiding this comment.
We should make sure the import schema is behaving the way we want it for the different versions.
Also,
ASSERT_EQ(m_ecdb.Schemas().ImportSchemas(context->GetCache().GetSchemas()), SchemaImportResult::OK / SchemaImportResult::ERROR)
Abhijeet-Bentley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link: iTwin/itwinjs-core#7473