Skip to content

Commit

Permalink
fix prepare-fork.ts (#212)
Browse files Browse the repository at this point in the history
When fed guid opt branch was merged there was a change in
initializeBranchProvenance() function which closed the master and branch
imodel if createFedGuidsForMaster: true,. Because of this when the test
tried to peform saveChanges() it would fail.
I decided to just remove save changes because performing .close() on the
imodels should save changes before closing. This should be better for
the context of a perf test so time isn't wasted reopening the imodel
just to save changes and then close again.

Co-authored-by: Daniel Rodriguez <[email protected]>
  • Loading branch information
DanRod1999 and DanRod1999 authored Oct 9, 2024
1 parent 69c07bb commit 87735ba
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
11 changes: 11 additions & 0 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,17 @@
"skipFiles": [
"<node_internals>/**"
]
},
{
"type": "node",
"request": "launch",
"name": "Performance tests",
"runtimeExecutable": "npm",
"cwd": "${workspaceFolder}/packages/performance-tests/test",
"runtimeArgs": [
"run",
"test"
],
}
]
}
3 changes: 0 additions & 3 deletions packages/performance-tests/test/cases/prepare-fork.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,6 @@ export default async function prepareFork(context: TestCaseContext) {
[timer] = await timed(async () => {
await branchInitializer.run();
});
// save+push our changes to whatever hub we're using
const description = "initialized branch iModel";
branchDb.saveChanges(description);

Logger.logInfo(
loggerCategory,
Expand Down

0 comments on commit 87735ba

Please sign in to comment.