Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if current user still holds the write lock when upload changes #7000

Draft
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

jiaruiz717
Copy link
Contributor

@jiaruiz717 jiaruiz717 commented Jul 23, 2024

iTwin/itwinjs-backlog#1170

There is a possible scenario that two users try to upload local changes to the same cloud container:

  1. User1 grabs the write lock and sit there for a very long time. User1 does not release the write lock even after it has expired
  2. User2 grabs the write lock after User1's write lock expires, and upload something to the cloud container
  3. User1 then tries to upload changes, we should disable User1 from uploading his changes because the write lock has expired

However, if there are no other users grab the write lock after User1, we allow User1 to upload changes(and refresh the write lock) even if the write lock has expired.

Native change:
imodel-native: iTwin/imodel-native#819

Copy link
Contributor

mergify bot commented Aug 9, 2024

This pull request is now in conflicts. Could you fix it @jiaruiz717? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

Copy link
Contributor

mergify bot commented Oct 24, 2024

This pull request is now in conflicts. Could you fix it @jiaruiz717? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

@aruniverse aruniverse marked this pull request as draft November 13, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants