Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add property constraints #7534

Merged
merged 21 commits into from
Jan 16, 2025
Merged

Add property constraints #7534

merged 21 commits into from
Jan 16, 2025

Conversation

JonasDov
Copy link
Contributor

@JonasDov JonasDov commented Jan 10, 2025 •
edited
Loading

imodel-native: iTwin/imodel-native#963

@JonasDov JonasDov requested review from ben-polinsky and a team as code owners January 10, 2025 13:28
@JonasDov JonasDov linked an issue Jan 10, 2025 that may be closed by this pull request
Support ECProperty value range iTwin/presentation#779
Open
This was referenced Jan 10, 2025
Merged
Draft
grigasp
grigasp reviewed Jan 10, 2025
View reviewed changes
Copy link
Member

@grigasp grigasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to have at least a single full stack test that confirms we get this information from the native addon.

@JonasDov
Copy link
Contributor Author

Would be great to have at least a single full stack test that confirms we get this information from the native addon.

Added 3 tests: one for array, one for string and one for numeric properties

grigasp
grigasp reviewed Jan 14, 2025
View reviewed changes
full-stack-tests/presentation/src/frontend/content/PrimitiveProperties.test.ts Outdated Show resolved Hide resolved
full-stack-tests/presentation/src/frontend/content/PrimitiveProperties.test.ts Outdated Show resolved Hide resolved
full-stack-tests/presentation/src/frontend/content/PrimitiveProperties.test.ts Outdated Show resolved Hide resolved
full-stack-tests/presentation/src/frontend/content/PrimitiveProperties.test.ts Outdated Show resolved Hide resolved
full-stack-tests/presentation/src/frontend/content/PrimitiveProperties.test.ts Outdated Show resolved Hide resolved
full-stack-tests/presentation/src/frontend/content/PrimitiveProperties.test.ts Outdated Show resolved Hide resolved
full-stack-tests/presentation/src/frontend/content/PrimitiveProperties.test.ts Outdated Show resolved Hide resolved
full-stack-tests/presentation/src/frontend/content/PrimitiveProperties.test.ts Outdated Show resolved Hide resolved
ui/appui-abstract/src/appui-abstract/properties/Description.ts Outdated Show resolved Hide resolved
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 15, 2025

This pull request is now in conflicts. Could you fix it @JonasDov? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

@grigasp grigasp merged commit 546a0a4 into master Jan 16, 2025
14 checks passed
@grigasp grigasp deleted the JonasD/property-coinstraints branch January 16, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben-polinsky ben-polinsky ben-polinsky left review comments

@aruniverse aruniverse aruniverse left review comments

@grigasp grigasp grigasp approved these changes

@calebmshafer calebmshafer Awaiting requested review from calebmshafer

@wgoehrig wgoehrig Awaiting requested review from wgoehrig

@ColinKerr ColinKerr Awaiting requested review from ColinKerr ColinKerr was automatically assigned from iTwin/itwinjs-core

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support ECProperty value range
5 participants
@JonasDov @aruniverse @grigasp @ben-polinsky @imodeljs-admin