Add onKeyDown property #161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iannbing
reviewed
Apr 10, 2020
| children: JSX.Element | string; | ||
| up: () => void; | ||
| down: () => void; | ||
| left: () => void; | ||
| right: () => void; | ||
| enter: () => void; | ||
| onKeyDown?: (event: KeyboardEvent<HTMLDivElement>) => any; |
There was a problem hiding this comment.
Since this function doesn't return any value, should it be (event: KeyboardEvent<HTMLDivElement>) => void?
iannbing
reviewed
Apr 10, 2020
| @@ -27,7 +27,8 @@ export type TreeMenuProps = { | |||
| locale?: LocaleFunction; | |||
| matchSearch?: MatchSearchFunction; | |||
| disableKeyboard?: boolean; | |||
| }; | |||
| onKeyDown?: () => any; | |||
There was a problem hiding this comment.
The typing is inconsistent with the others. It should be onKeyDown?: (event: KeyboardEvent<HTMLDivElement>) => void?
iannbing
reviewed
Apr 10, 2020
| @@ -167,6 +167,7 @@ Note the difference between the state `active` and `focused`. ENTER is equivalen | |||
| | initialActiveKey | set initial state of `activeKey`. Note that you need to provide the complete path (e.g. node-level-1/node-level-2/target-node). | string | - | | |||
| | initialFocusKey | set initial state of `focusKey`. Note that you need to provide the complete path (e.g. node-level-1/node-level-2/target-node). | string | - | | |||
| | onClickItem | A callback function that defines the behavior when user clicks on an node | (Item): void | `console.warn` | | |||
| | onKeyDown | A callback function that will be run after the keyboard navigation event | (event: KeyboardEvent<HTMLDivElement>) => any| - | | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.