One more UTC bugfix for the road #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So, most of the UTC repairs we performed last year were correct, except for this one. Unix "epochs" by themselves are timezone-less. It's when they are "interpreted" as human-readable timestamps that they are parsed by python incorrectly. When these epochs (from time()) are directly compared to each other, they are timezone-less, and do not need to be offset. But, when they are "fed" to python to be converted as human-readable, those rare cases are when the timezones get lost. We've already handled correctly in the past when human timestamps are compared to human timestamps --- that all works fine --- no repair needed there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, most of the UTC repairs we performed last year were correct, except for this one.
Unix "epochs" by themselves are timezone-less. It's when they are "interpreted" as human-readable
timestamps that they are parsed by python incorrectly.
When these epochs (from time()) are directly compared to each other, they are timezone-less,
and do not need to be offset.
But, when they are "fed" to python to be converted as human-readable, those rare cases are
when the timezones get lost.
We've already handled correctly in the past when human timestamps are compared to human
timestamps --- that all works fine --- no repair needed there.