Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rc/1.87.5 #1197

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Rc/1.87.5 #1197

merged 3 commits into from
Sep 27, 2024

Conversation

demariadaniel
Copy link
Contributor

Link to Issue

Drug Field Validation

Description

Checklist

Type of Change

  • Bug
  • Refactor
  • New Feature
  • Release Candidate

Checklist before requesting review:

  • Check branch (code change PRs go to develop not master)
  • Check copyrights for new files
  • Manual testing
  • Regression tests completed and passing (double check number of tests).
  • Spelling has been checked.
  • Updated swagger docs accordingly (check it's still valid)
  • Set validationDependency in meta tag for Argo Dictionary fields used in code

* Stub new Unit Test

* First Field / Test Updates

* Stub Validator Function

* Updated imports (automated)

* Destructure Drug Fields

* Unit Test with first validation

* Success Case testing Immune / Hormone Therapy

* Update tests for individual entities

* Refactor

* Move to Therapies, working on Swagger (draft)

* Consistent Names, Add Messages

* Names + Early Return

* Updated therapy tests

* Fix therapy type logic, remove test changes

* Remove Missing Drug Info (unused)

* Unsaved change

* Unsaved Error removed

* Condensed validation
joneubank
joneubank previously approved these changes Sep 27, 2024
@demariadaniel demariadaniel dismissed joneubank’s stale review September 27, 2024 21:06

The merge-base changed after approval.

@joneubank joneubank self-requested a review September 27, 2024 21:07
@demariadaniel demariadaniel merged commit 22fde02 into master Sep 27, 2024
@demariadaniel demariadaniel deleted the rc/1.87.5 branch September 27, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants