-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mass number matching #330
mass number matching #330
Conversation
Job Precheck on 55da0b2 : invalidated by @brianmoose Added clang format check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test would be nice to have
cff5205
to
e3e32aa
Compare
I forgot that we currently match only by |
Actually, shouldn't we do the mass number range by variable in the rasterizer? If it's not supplied it's set to a vector of |
e3e32aa
to
111903e
Compare
Job Precheck on 111903e wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
111903e
to
38cf638
Compare
{ | ||
} | ||
|
||
std::vector<Real> _elements; | ||
std::vector<Real> _Z; | ||
std::vector<Real> _M; | ||
std::vector<Real> _M_tol; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not seem right. AveragedData
is stored in a map with an entry for every active element. I don't think we'll need spatially varying mass tolerance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same is should then be true for _M
and _Z
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes... I think you're right!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they could be accessed directly from the rasterizer then.
38cf638
to
e389551
Compare
@@ -67,7 +67,7 @@ class MyTRIMRasterizer : public ElementUserObject | |||
struct PKAParameters | |||
{ | |||
/// masses charges (m_i, Z_i) of the matrix elements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment should be updated
e389551
to
45a6656
Compare
refs #300