Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wider support for T_from_p_h for fluid properties #29620

Open
GiudGiud opened this issue Dec 26, 2024 · 0 comments
Open

Add wider support for T_from_p_h for fluid properties #29620

GiudGiud opened this issue Dec 26, 2024 · 0 comments
Labels
C: Modules/Fluid Properties Tickets pertaining to the fluid_properties module T: task An enhancement to the software.

Comments

@GiudGiud
Copy link
Contributor

GiudGiud commented Dec 26, 2024

Motivation

This is needed in multiple places:
according to #12108, it's needed in SAM in a branch
it's used by subchannel in the initialization phase
It's going to be used by the main Navier Stokes solver

Design

Implement T_from_p_h directly in each of the fluid properties object

  • either figure out the math to invert h(p, T) usually
  • or use Newton (on h(p, T))
  • or use the derivation in SinglePhaseFluidProperties (can be expensive, through s_from_h_p, rho_from_p_s, e_from_v_h)

Impact

More useful fluid properties module
Faster FP computations

@GiudGiud GiudGiud added T: task An enhancement to the software. C: Modules/Fluid Properties Tickets pertaining to the fluid_properties module labels Dec 26, 2024
GiudGiud added a commit to GiudGiud/moose that referenced this issue Dec 26, 2024
GiudGiud added a commit to GiudGiud/moose that referenced this issue Dec 26, 2024
GiudGiud added a commit to GiudGiud/moose that referenced this issue Dec 26, 2024
Use a single Newton inversion rather than 3 calls through SFP definition of T(p,h)
refs idaholab#29620
GiudGiud added a commit to GiudGiud/moose that referenced this issue Dec 26, 2024
GiudGiud added a commit to GiudGiud/moose that referenced this issue Dec 26, 2024
GiudGiud added a commit to GiudGiud/moose that referenced this issue Dec 26, 2024
GiudGiud added a commit to GiudGiud/moose that referenced this issue Dec 26, 2024
as a Newton inversion of h(p,T) in HelmhotzFP refs idaholab#29620
GiudGiud added a commit to GiudGiud/moose that referenced this issue Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Modules/Fluid Properties Tickets pertaining to the fluid_properties module T: task An enhancement to the software.
Projects
None yet
Development

No branches or pull requests

1 participant