Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for T_from_p_h in a few fluid properties #29621

Open
wants to merge 7 commits into
base: next
Choose a base branch
from

Conversation

GiudGiud
Copy link
Contributor

refs #29620

@GiudGiud GiudGiud self-assigned this Dec 26, 2024
@moosebuild
Copy link
Contributor

moosebuild commented Dec 27, 2024

Job Documentation, step Docs: sync website on f7a3ba3 wanted to post the following:

View the site here

This comment will be updated on new commits.

@GiudGiud GiudGiud marked this pull request as ready for review December 27, 2024 07:49
@GiudGiud
Copy link
Contributor Author

test failures are fake news

@joshuahansel
Copy link
Contributor

Beautiful expressions. They pass the consistency check at least. So I'll approve after tests pass.

@moosebuild
Copy link
Contributor

moosebuild commented Jan 3, 2025

Job Coverage, step Generate coverage on f7a3ba3 wanted to post the following:

Framework coverage

Mutiple base shas were found when retrieving head reports:
44e87a4
1e17680

Modules coverage

Fluid properties

44e87a #29621 f7a3ba
Total Total +/- New
Rate 85.19% 85.11% -0.08% 86.36%
Hits 7777 7850 +73 114
Misses 1352 1373 +21 18

Diff coverage report

Full coverage report

Full coverage reports

Reports

Warnings

  • fluid_properties new line coverage rate 86.36% is less than the suggested 90.0%

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Coverage, step Verify coverage on 4dc16dd wanted to post the following:

The following coverage requirement(s) failed:

  • Failed to generate framework coverage rate (required: 81.0%)

@GiudGiud
Copy link
Contributor Author

GiudGiud commented Jan 3, 2025

should be good now?

@GiudGiud
Copy link
Contributor Author

GiudGiud commented Jan 6, 2025

doco recipe froze, no change in doco expected to break doco

@moosebuild
Copy link
Contributor

Job Coverage, step Verify coverage on f7a3ba3 wanted to post the following:

The following coverage requirement(s) failed:

  • Failed to generate framework coverage rate (required: 81.0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants