Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add consistent scaling for optimization problems #29571

Open
wants to merge 4 commits into
base: next
Choose a base branch
from
Open

Add consistent scaling for optimization problems #29571

wants to merge 4 commits into from

Conversation

maxnezdyur
Copy link
Contributor

closes #29570

@maxnezdyur
Copy link
Contributor Author

@lynnmunday
This fixes the scaling problems.

@dschwen dschwen changed the title add consistent scaling for optimization problems #29570 Add consistent scaling for optimization problems Dec 18, 2024
@maxnezdyur maxnezdyur force-pushed the cons_scaling branch 2 times, most recently from 4d6fc7d to 75dd85b Compare December 18, 2024 20:38
@moosebuild
Copy link
Contributor

moosebuild commented Dec 18, 2024 •
edited
Loading

Job Documentation, step Docs: sync website on 14840a3 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

moosebuild commented Jan 2, 2025 •
edited
Loading

Job Coverage, step Generate coverage on 14840a3 wanted to post the following:

Framework coverage

1e1768 #29571 14840a
Total Total +/- New
Rate 85.25% 85.25% -0.00% -
Hits 108011 108009 -2 0
Misses 18681 18683 +2 0

Diff coverage report

Full coverage report

Modules coverage

Optimization

1e1768 #29571 14840a
Total Total +/- New
Rate 88.07% 88.06% -0.01% 87.50%
Hits 1957 1962 +5 7
Misses 265 266 +1 1

Diff coverage report

Full coverage report

Full coverage reports

Reports

Warnings

  • optimization new line coverage rate 87.50% is less than the suggested 90.0%

This comment will be updated on new commits.

@GiudGiud GiudGiud self-assigned this Jan 4, 2025
@maxnezdyur maxnezdyur requested a review from GiudGiud January 6, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lynnmunday lynnmunday lynnmunday approved these changes

@zachmprince zachmprince Awaiting requested review from zachmprince zachmprince is a code owner

@dschwen dschwen Awaiting requested review from dschwen dschwen is a code owner

@GiudGiud GiudGiud Awaiting requested review from GiudGiud

At least 1 approving review is required to merge this pull request.

Assignees

@GiudGiud GiudGiud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimization Auto Adjoint doesn't work with scaling of the system
4 participants
@maxnezdyur @moosebuild @GiudGiud @lynnmunday