-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add time transformation #29640
base: next
Are you sure you want to change the base?
Add time transformation #29640
Conversation
5e1aea7
to
a097131
Compare
Job Precheck, step Clang format on a097131 wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
36bc35d
to
061e9c5
Compare
Job Documentation, step Docs: sync website on 1cc4a29 wanted to post the following: View the site here This comment will be updated on new commits. |
Job Coverage, step Generate coverage on 1cc4a29 wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
Warnings
This comment will be updated on new commits. |
Phase field test shows there's a solution initialization issue. Should add a call to initial setup on the new transformation function
function* not solution |
No the time in the solution in the Solution user object |
the function that gives you the transformation, probably needs a initialSetup call on it before it gets used in that phase field test |
I'll clarify the doc string. I'm surprised at the initialization issue. No initialization was performed before the pr, and the change should not affect behavior with the default function (identity). :-/ |
before the PR, you did not create a parsed function like this in a parameter? I m not sure there were any parsed functions involved in that object, which executes rather early |
Fingers crossed that the early function initialization doesn't break other stuff... |
97cd84a
to
ebce148
Compare
If this doesn't pass I'm rolling back the changes I made to SolUO (moving initialization from initialSetup to the constructor). The root problem is the function requiring access to the userobject to get the name of the variable in the solution file. This currently prevents moving Function initialSetup before UO initialSetup. IMO we should just get rid of that small convenience where the user doesn't have to specify a variable name anywhere, as long as the solution only contains a single variable. That scenario seems like an edge case, and having the variable stated explicitly in the input seems more expressive. |
6d489af
to
1cc4a29
Compare
1cc4a29
to
0d9b1a1
Compare
Closes #29639