Fix DELREQUIRES #32
Open
Fix DELREQUIRES #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When DELREQUIRES is specified, the old algorithm's double for-loop did not actually remove any of the DELREQUIRES entries from the REQUIRES list. Switch the logic of the double for-loop around so that every item in INFOREQUIRES is tested against the entire list of DELREQUIRES (and '%README%'), and only when it never matches then add it to newreqlist. The "break" statement in the inner for-loop is an optimization and not strictly needed. It bails out of the inner for-loop as soon as we've found a match in the DELREQUIRES (or '%README%') list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When DELREQUIRES is specified, the old algorithm's double for-loop did
not actually remove any of the DELREQUIRES entries from the REQUIRES
list. Switch the logic of the double for-loop around so that every item
in INFOREQUIRES is tested against the entire list of DELREQUIRES (and
'%README%'), and only when it never matches then add it to newreqlist.
The "break" statement in the inner for-loop is an optimization and not
strictly needed. It bails out of the inner for-loop as soon as we've
found a match in the DELREQUIRES (or '%README%') list.