Skip to content

outerContainerStyle & icon functions #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

TimBroddin
Copy link

@TimBroddin TimBroddin commented Apr 11, 2020

Hi Johan,

Nice library! I made two small changes:

  • I've added an outerContainerStyle prop to be able to style the outer container. I needed to have it position relative in my app.
  • I've changed the icon property to also accept a function. This way I could include icons from FontAwesome5. Color and size are passed as props:
            {
              icon: ({ color, size }) => (
                <Icon name="compass" size={size} color={color} />
              ),
              color: "rgb(130, 130, 130)",
              activeColor: "rgb(3, 137, 253)",
              activeBackgroundColor: "rgb(224, 243, 255)"
            },

I was lazy and did all the editing in the Github editor, so that explains the many commits included in this pull request.

Tim

ImgBotApp and others added 9 commits April 10, 2020 10:01
*Total -- 9.72kb -> 8.50kb (12.61%)

/assets/horizontal-action-bar.png -- 4.64kb -> 4.00kb (13.77%)
/assets/vertical-action-bar.png -- 5.08kb -> 4.49kb (11.54%)

Signed-off-by: ImgBotApp <[email protected]>
add containerStyle prop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants