-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor subscribers and handle errors better #312
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 question about filenaming but otherwise good to merge
@@ -0,0 +1,58 @@ | |||
# Copyright (C) idoneam (2016-2020) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this file be named differently to avoid confusing its purpose with cogs/subscribers.py
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, could be a good idea to catch the exceptions happening in check_metro_status directly too. But this shouldn't crash anymore, and I tested and subscriber.py still works (food recalls were sent)
@le-potate will this conflict at all with the webhook logger stuff? |
Description
Motivation and Context
How Has This Been Tested?
Checklist: