-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build on Nixpkgs/NixOS #4405
base: master
Are you sure you want to change the base?
Build on Nixpkgs/NixOS #4405
Changes from 7 commits
ab23462
0e0bd1a
52d9600
44df85b
150e586
f723856
8009e2b
55dc5db
af91928
5b018fe
b6ed5d0
2b60976
6a2151b
f1ef4c6
9db7c86
78d6af9
734e480
caccebd
4c23999
3e6e470
cf3d89f
cc13c44
405c415
8d76d46
70e2514
5e209f1
42616f9
93d5656
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
{ nixpkgs ? import <nixpkgs> {}, compiler ? "ghc822" }: | ||
nixpkgs.pkgs.haskell.packages.${compiler}.callPackage ./idris.nix { } |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -108,12 +108,12 @@ custom-setup | |
|
||
Flag FFI | ||
Description: Build support for libffi | ||
Default: False | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These flags should stay as they are, because libffi can be difficult for Mac users and some people don't like the license of GMP. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And I agree, I'm sort of asking how should this be handled in the second bullet point. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think that their behavior should remain unchanged in the .cabal file at least. Nix users are a minority of Idris users, and I don't think that we should make it more difficult to build it the common way to make Nix packaging easier. |
||
Default: True | ||
manual: True | ||
|
||
Flag GMP | ||
Description: Use GMP for Integers | ||
Default: False | ||
Default: True | ||
manual: True | ||
|
||
-- This flag determines whether to show Git hashes in version strings | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of renaming the CABAL and MAKE variables? These shorter versions are (slightly) more difficult for me to understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those try to ensure the correct
idris
is invoked viaenv IDRIS=$(IDRIS) ...
and I simply used those. I'm not particularly attached to any of those names though, what would you suggest?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not leave them as they were?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean? Repeat explicitly like in
env IDRIS=$(IDRIS) $(MAKE)
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was commenting on renaming the CABAL variable to CB here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uses the original names now.