Skip to content

Improved error messages when reading and validating an invalid grid #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 9, 2025
Merged

Improved error messages when reading and validating an invalid grid #1355

merged 10 commits into from
Jul 9, 2025

Conversation

staudtMarius
Copy link
Member

@staudtMarius staudtMarius commented Jul 2, 2025 •
edited
Loading

Resolves #1354

@staudtMarius staudtMarius self-assigned this Jul 2, 2025
@staudtMarius staudtMarius added the enhancement New feature or request label Jul 2, 2025
@staudtMarius staudtMarius marked this pull request as ready for review July 3, 2025 12:17
danielfeismann
danielfeismann requested changes Jul 8, 2025
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts from my side. But overall I like the idea to improve readability the error messages of the validation

@danielfeismann
Copy link
Member

Could you please have also a look on the sonar issues?

danielfeismann
danielfeismann requested changes Jul 9, 2025
View reviewed changes
danielfeismann
danielfeismann approved these changes Jul 9, 2025
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of my points. LGTM!

@danielfeismann danielfeismann merged commit 7e14215 into dev Jul 9, 2025
4 checks passed
@danielfeismann danielfeismann deleted the ms/#1354-improve-exception-messages-for-reading-and-validating-a-grid branch July 9, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfeismann danielfeismann danielfeismann approved these changes

@sebastian-peter sebastian-peter Awaiting requested review from sebastian-peter

Assignees

@staudtMarius staudtMarius

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve exception messages for reading and validating a grid
2 participants
@staudtMarius @danielfeismann