Skip to content

Factory case class in BmModel and BmInput case in GridAgentBuilder #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 7, 2025
Merged

Factory case class in BmModel and BmInput case in GridAgentBuilder #1360

merged 11 commits into from
May 7, 2025

Conversation

marvinheintze
Copy link
Contributor

@marvinheintze marvinheintze commented Apr 24, 2025 •
edited by staudtMarius
Loading

Resolves #84
Resolves #1332

Added Factory case class in BmModel and BmInput case in GridAgentBuilder

@marvinheintze marvinheintze self-assigned this Apr 24, 2025
@marvinheintze marvinheintze added the enhancement New feature or request label Apr 29, 2025
@staudtMarius
Copy link
Member

@marvinheintze
Two small comments from my side:

  1. Could you add the BmFactory to the method getPhysicalModelFactory in ParticipantModelInit.?
  2. Could you remove the filtering of BmInput in GridAgentBuilder.filterSysParts?

staudtMarius
staudtMarius requested changes Apr 30, 2025
View reviewed changes
Copy link
Member

@staudtMarius staudtMarius left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one small remark from my side.

@staudtMarius staudtMarius self-requested a review May 6, 2025 10:32
staudtMarius
staudtMarius previously approved these changes May 6, 2025
View reviewed changes
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sebastian-peter
sebastian-peter requested changes May 6, 2025
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small points from my side

@staudtMarius staudtMarius mentioned this pull request May 6, 2025
Closed
sebastian-peter
sebastian-peter requested changes May 7, 2025
View reviewed changes
@sebastian-peter
Copy link
Member

Thanks everyone!

@sebastian-peter sebastian-peter merged commit 7ca3b1e into dev May 7, 2025
3 checks passed
@sebastian-peter sebastian-peter deleted the mh/#1332-introducing-BmModel-to-ParticipantAgent branch May 7, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-peter sebastian-peter sebastian-peter approved these changes

@staudtMarius staudtMarius staudtMarius left review comments

Assignees

@marvinheintze marvinheintze

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce BmModelto ParticipantAgent Implement agent for biomass power plants
3 participants
@marvinheintze @staudtMarius @sebastian-peter