Conditionally export as a module #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we're in node, we export the function as a module. If not, we simply invoke the function with jQuery (in the current scope).
|
@vjt FYI I did not have an opportunity to test this in the browser so I can't verify that it's working as expected there. FWIW this did not end up serving my purposes because it relies on jquery-ujs and we're using plain old rails-ujs instead. |
|
This looks very good, thanks. I am sorry for the delay in providing an update. As reported by @CyberDeck, this code works with |
vjt
added a commit
that referenced
this pull request
Oct 14, 2017
|
Thanks for your help. I have reworked these changes and included them in #58. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #53. There's a lot that could be done to make this better (e.g. auto-invocation unless you import a named part of the module, removing the dependence on jQuery, etc.), but I promised @vjt a PR so here's the next step!