Skip to content

Fix Style/HashFetchChain offense #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged

Conversation

tagliala
Copy link
Member

@tagliala tagliala commented Apr 1, 2025

This cop is marked as unsafe, but for this specific use case, the offense should be safe to autofix

Comparison (IPS):
                 dig: 11134481.1 i/s
         fetch_chain:  6504560.8 i/s - 1.71x  (± 0.00) slower

Comparison (Memory):
                 dig:          0 allocated
         fetch_chain:        160 allocated - Infx more

This cop is marked as unsafe, but for this specific use case, the
offense should be safe to autofix

```
Comparison (IPS):
                 dig: 11134481.1 i/s
         fetch_chain:  6504560.8 i/s - 1.71x  (± 0.00) slower

Comparison (Memory):
                 dig:          0 allocated
         fetch_chain:        160 allocated - Infx more
```
@tagliala tagliala merged commit e8b4a5e into master Apr 1, 2025
24 checks passed
@tagliala tagliala deleted the chore/fix-hash-fetch-chain branch April 1, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant