Fix order of expected elements in smallest elements test #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakepat
changed the title
blakepat
force-pushed
the
fix-smallest-elements-test
branch
from
9dff22d to
3c4c262
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the order of elements in the "2 smallest elements" test case to maintain the original sequence order.
Changed:
smallestElements(list, 2) shouldBeEqualTo listOf(3, 1)
To:
smallestElements(list, 2) shouldBeEqualTo listOf(1, 3)
The order [1, 3] is correct because it preserves the order these elements appeared in the original list [5, 1, 3].
Note: The build is failing due to missing Test classes in other challenge files (anycallback, advancedlru). These issues should be addressed separately as they are unrelated to this specific test fix.